- 20 6月, 2024 1 次提交
-
-
由 Jeremy Reizenstein 创作于
Summary: Fix for "undefined symbol: iJIT_NotifyEvent" build issue, Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1820 Differential Revision: D58685326
-
- 17 6月, 2024 4 次提交
-
-
由 vedrenne 创作于
Summary: Currently, it is not possible to access a sub-transform using an indexer for all 3d transforms inheriting the `Transforms3d` class. For instance: ```python from pytorch3d import transforms N = 10 r = transforms.random_rotations(N) T = transforms.Transform3d().rotate(R=r) R = transforms.Rotate(r) x = T[0] # ok x = R[0] # TypeError: __init__() got an unexpected keyword argument 'matrix' ``` This is because all these classes (namely `Rotate`, `Translate`, `Scale`, `RotateAxisAngle`) inherit the `__getitem__()` method from `Transform3d` which has the [following code on line 201](https://github.com/facebookresearch/pytorch3d/blob/main/pytorch3d/transforms/transform3d.py#L201): ```python return self.__class__(matrix=self.get_matrix()[index]) ``` The four classes inheriting `Transform3d` are not initialized through a matrix argument, hence they error. I propose to modify the `__getitem__()` method of the `Transform3d` class to fix this behavior. The least invasive way to do it I can think of consists of creating an empty instance of the current class, then setting the `_matrix` attribute manually. Thus, instead of ```python return self.__class__(matrix=self.get_matrix()[index]) ``` I propose to do: ```python instance = self.__class__.__new__(self.__class__) instance._matrix = self.get_matrix()[index] return instance ``` As far as I can tell, this modification occurs no modification whatsoever for the user, except for the ability to index all 3d transforms. Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1801 Reviewed By: MichaelRamamonjisoa Differential Revision: D58410389 Pulled By: bottler fbshipit-source-id: f371e4c63d2ae4c927a7ad48c2de8862761078de
-
由 Jeremy Reizenstein 创作于
Summary: Undoes the pytorch3d changes in D57294278 because they break builds for for PyTorch<2.1 . Reviewed By: MichaelRamamonjisoa Differential Revision: D57379779 fbshipit-source-id: 47a12511abcec4c3f4e2f62eff5ba99deb2fab4c
-
由 Kyle Vedder 创作于
Summary: Currently, it checks that the `2`th dimension of `p2` is the same size as the `2`th dimension of `p2` instead of `p1`. Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1815 Reviewed By: MichaelRamamonjisoa Differential Revision: D58586966 Pulled By: bottler fbshipit-source-id: d4f723fa264f90fe368c10825c1acdfdc4c406dc
-
由 Jeremy Reizenstein 创作于
Summary: Build for new pytorch versions Reviewed By: MichaelRamamonjisoa Differential Revision: D58668956 fbshipit-source-id: 7fdfb377b370448d6147daded6a21b8db87586fb
-
- 30 5月, 2024 1 次提交
-
-
由 Roman Shapovalov 创作于
Summary: We can now move ray bundle to float dtype (e.g. from fp16 like types). Reviewed By: bottler Differential Revision: D57493109 fbshipit-source-id: 4e18a427e968b646fe5feafbff653811cd007981
-
- 13 5月, 2024 1 次提交
-
-
由 Richard Barnes 创作于
Summary: `c10::optional` was switched to be `std::optional` after PyTorch moved to C++17. Let's eliminate `c10::optional`, if we can. Reviewed By: albanD Differential Revision: D57294278 fbshipit-source-id: f6f26133c43f8d92a4588f59df7d689e7909a0cd
-
- 10 5月, 2024 1 次提交
-
-
Differential Revision: D57183103 fbshipit-source-id: 7e2f42ddc6a1fa02abc27a451987d67a00264cbb
-
- 02 5月, 2024 1 次提交
-
-
由 Richard Barnes 创作于
Remove unused-but-set variables in vision/fair/pytorch3d/pytorch3d/csrc/pulsar/include/renderer.render.device.h +1 Summary: This diff removes a variable that was set, but which was not used. LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance. Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging. For questions/comments, contact r-barnes. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: bottler Differential Revision: D56886956 fbshipit-source-id: 0c515ed98b812b1c106a59e19ec90751ce32e8c0
-
- 14 4月, 2024 1 次提交
-
-
由 Andres Suarez 创作于
Summary: Previously this code conformed from clang-format 12. Reviewed By: igorsugak Differential Revision: D56065247 fbshipit-source-id: f5a985dd8f8b84f2f9e1818b3719b43c5a1b05b3
-
- 03 4月, 2024 1 次提交
-
-
Differential Revision: D55650177 fbshipit-source-id: d5faa4d805bb40fe3dea70b0601e7a1382b09f3a
-
- 02 4月, 2024 2 次提交
-
-
由 Ruishen Lyu 创作于
Summary: For larger N and Mi value (e.g. N=154, Mi=238) I notice list_to_packed() has become a bottleneck for my application. By removing the for loop and running on GPU, i see a 10-20 x speedup. Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1737 Reviewed By: MichaelRamamonjisoa Differential Revision: D54187993 Pulled By: bottler fbshipit-source-id: 16399a24cb63b48c30460c7d960abef603b115d0
-
由 Ashim Dahal 创作于
Summary: adjusted sample_nums to match the number of columns in the image grid. It originally produced image grid with 5 axes but only 3 images and after this fix, the block would work as intended. Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1768 Reviewed By: MichaelRamamonjisoa Differential Revision: D55632872 Pulled By: bottler fbshipit-source-id: 44d633a8068076889e49d49b8a7910dba0db37a7
-
- 28 3月, 2024 1 次提交
-
-
由 Roeia Kishk 创作于
Summary: ### Generalise tutorials' pip searching: ## Required Information: This diff contains changes to several PyTorch3D tutorials. **Purpose of this diff:** Replace the current installation code with a more streamlined approach that tries to install the wheel first and falls back to installing from source if the wheel is not found. **Why this diff is required:** This diff makes it easier to cope with new PyTorch releases and reduce the need for manual intervention, as the current process involves checking the version of PyTorch in Colab and building a new wheel if it doesn't match the expected version, which generates additional work each time there is a a new PyTorch version in Colab. **Changes:** Before: ``` if torch.__version__.startswith("2.1.") and sys.platform.startswith("linux"): # We try to install PyTorch3D via a released wheel. pyt_version_str=torch.__version__.split("+")[0].replace(".", "") version_str="".join([ f"py3{sys.version_info.minor}_cu", torch.version.cuda.replace(".",""), f"_pyt{pyt_version_str}" ]) !pip install fvcore iopath !pip install --no-index --no-cache-dir pytorch3d -f https://dl.fbaipublicfiles.com/pytorch3d/packaging/wheels/{version_str}/download.html else: # We try to install PyTorch3D from source. !pip install 'git+https://github.com/facebookresearch/pytorch3d.git@stable' ``` After: ``` pyt_version_str=torch.__version__.split("+")[0].replace(".", "") version_str="".join([ f"py3{sys.version_info.minor}_cu", torch.version.cuda.replace(".",""), f"_pyt{pyt_version_str}" ]) !pip install fvcore iopath if sys.platform.startswith("linux"): # We try to install PyTorch3D via a released wheel. !pip install --no-index --no-cache-dir pytorch3d -f https://dl.fbaipublicfiles.com/pytorch3d/packaging/wheels/{version_str}/download.html pip_list = !pip freeze need_pytorch3d = not any(i.startswith("pytorch3d==") for i in pip_list) if need_pytorch3d: # We try to install PyTorch3D from source. !pip install 'git+https://github.com/facebookresearch/pytorch3d.git@stable' ``` Reviewed By: bottler Differential Revision: D55431832 fbshipit-source-id: a8de9162470698320241ae8401427dcb1ce17c37
-
- 27 3月, 2024 1 次提交
-
-
Differential Revision: D55395614 fbshipit-source-id: 71677892b5d6f219f6df25b4efb51fb0f6b1441b
-
- 12 3月, 2024 1 次提交
-
-
由 Cijo Jose 创作于
Summary: Implements the the TexturesUV with multiple map ids. Reviewed By: bottler Differential Revision: D53944063 fbshipit-source-id: 06c25eb6d69f72db0484f16566dd2ca32a560b82
-
- 07 3月, 2024 1 次提交
-
-
由 Jaap Suter 创作于
Summary: Fix an inclusive vs exclusive scan mix-up that was accidentally introduced when removing the Thrust dependency (`Thrust::exclusive_scan`) and reimplementing it using `at::cumsum` (which does an inclusive scan). This fixes two Github reported issues: * https://github.com/facebookresearch/pytorch3d/issues/1731 * https://github.com/facebookresearch/pytorch3d/issues/1751 Reviewed By: bottler Differential Revision: D54605545 fbshipit-source-id: da9e92f3f8a9a35f7b7191428d0b9a9ca03e0d4d
-
- 05 3月, 2024 1 次提交
-
-
由 Conner Nilsen 创作于
Reviewed By: inseokhwang Differential Revision: D54438157 fbshipit-source-id: a6acfe146ed29fff82123b5e458906d4b4cee6a2
-
- 03 3月, 2024 1 次提交
-
-
由 Amethyst Reese 创作于
Summary: Formats the covered files with pyfmt. paintitblack Reviewed By: aleivag Differential Revision: D54447727 fbshipit-source-id: 8844b1caa08de94d04ac4df3c768dbf8c865fd2f
-
- 19 2月, 2024 2 次提交
-
-
由 Jeremy Reizenstein 创作于
Summary: New version Reviewed By: cijose Differential Revision: D53852987 fbshipit-source-id: 962ab9f61153883df9da0601356bd6b108dc5df7
-
由 Jeremy Reizenstein 创作于
Summary: version number changed with `sed -i "s/2.1\./2.2./" *b` Reviewed By: cijose Differential Revision: D53852986 fbshipit-source-id: 1662c8e6d671321887a3263bc3880d5c33d1f866
-
- 16 2月, 2024 1 次提交
-
-
由 Cijo Jose 创作于
Summary: The diff support colors in cubify for align = "center" Reviewed By: bottler Differential Revision: D53777011 fbshipit-source-id: ccb2bd1e3d89be3d1ac943eff08f40e50b0540d9
-
- 13 2月, 2024 1 次提交
-
-
由 Jeremy Reizenstein 创作于
Summary: Add an option to run tests without the OpenGL Renderer. Reviewed By: patricklabatut Differential Revision: D53573400 fbshipit-source-id: 54a14e7b2f156d24e0c561fdb279f4a9af01b793
-
- 08 2月, 2024 1 次提交
-
-
由 Ada Martin 创作于
Summary: Fixes https://github.com/facebookresearch/pytorch3d/issues/1641. The bug was caused by the mistaken downcasting of an int64_t into int, causing issues only on inputs large enough to have hashes that escaped the bounds of an int32. Also added a test case for this issue. Reviewed By: bottler Differential Revision: D53505370 fbshipit-source-id: 0fdd0efc6d259cc3b0263e7ff3a4ab2c648ec521
-
- 07 2月, 2024 1 次提交
-
-
由 Jeremy Reizenstein 创作于
Summary: Build for new pytorch versions Reviewed By: shapovalov Differential Revision: D53266104 fbshipit-source-id: f7aaacaf39cab3839b24f45361c36f087d0ea7c9
-
- 31 1月, 2024 1 次提交
-
-
Reviewed By: zsol Differential Revision: D53258682 fbshipit-source-id: 3f006b5f31a2b1ffdc6323d3a3b08ac46c3162ce
-
- 27 1月, 2024 1 次提交
-
-
Differential Revision: D53152021 fbshipit-source-id: 78be99b00abe4d992db844ff5877a89d42d468af
-
- 26 1月, 2024 1 次提交
-
-
Differential Revision: D53111480 fbshipit-source-id: 0f506bf29cf908e40b058ae72f51e828cd597825
-
- 25 1月, 2024 1 次提交
-
-
Differential Revision: D53059851 fbshipit-source-id: f5d0951186c858f90ddf550323a163e4b6d42b68
-
- 18 1月, 2024 1 次提交
-
-
由 Dimitris Prountzos 创作于
Summary: This change updates the type of p2_idx from size_t to int64_t to address compiler warnings related to signed/unsigned comparison. Reviewed By: bottler Differential Revision: D52879393 fbshipit-source-id: de5484d78a907fccdaae3ce036b5e4a1a0a4de70
-
- 16 1月, 2024 1 次提交
-
-
由 Ido Zachevsky 创作于
Summary: Fixed `get_rgbd_point_cloud` to take any number of image input channels. Reviewed By: bottler Differential Revision: D52796276 fbshipit-source-id: 3ddc0d1e337a6cc53fc86c40a6ddb136f036f9bc
-
- 04 1月, 2024 1 次提交
-
-
由 Abdelrahman Selim 创作于
Summary: Replace implementations of `so3_exp_map` and `so3_log_map` in so3.py with existing more-stable implementations. Reviewed By: bottler Differential Revision: D52513319 fbshipit-source-id: fbfc039643fef284d8baa11bab61651964077afe
-
- 03 1月, 2024 1 次提交
-
-
由 Jeremy Reizenstein 创作于
Summary: Fix for https://github.com/facebookresearch/pytorch3d/issues/1708 Reviewed By: patricklabatut Differential Revision: D52480756 fbshipit-source-id: 530c0f9413970fba042eec354e28318c96e35f42
-
- 21 12月, 2023 2 次提交
-
-
由 Abdelrahman Selim 创作于
Summary: An OSS user has pointed out in https://github.com/facebookresearch/pytorch3d/issues/1703 that the output of matrix_to_quaternion (in that file) can be non standardized. This diff solves the issue by adding a line of standardize at the end of the function Reviewed By: bottler Differential Revision: D52368721 fbshipit-source-id: c8d0426307fcdb7fd165e032572382d5ae360cde
-
由 Tony Tan 创作于
Summary: Implement submeshing for TexturesAtlas and add associated test Reviewed By: bottler Differential Revision: D52334053 fbshipit-source-id: d54080e9af1f0c01551702736e858e3bd439ac58
-
- 19 12月, 2023 1 次提交
-
-
由 Hassan Lotfi 创作于
Summary: Implement `submeshes` for TexturesUV. Fix what Meshes.submeshes passes to the texture's submeshes function to make this possible. Reviewed By: bottler Differential Revision: D52192060 fbshipit-source-id: 526734962e3376aaf75654200164cdcebfff6997
-
- 11 12月, 2023 1 次提交
-
-
由 Eric Young 创作于
Summary: Performance improvement: Use torch.lerp to map uv coordinates to the range needed for grid_sample (i.e. map [0, 1] to [-1, 1] and invert the y-axis) Reviewed By: bottler Differential Revision: D51961728 fbshipit-source-id: db19a5e3f482e9af7b96b20f88a1e5d0076dac43
-
- 07 12月, 2023 2 次提交
-
-
由 Roman Shapovalov 创作于
Summary: Porting this commit by davnov134 . https://github.com/fairinternal/pytorch3d/commit/93a3a62800799c73758505c6397ac7a1440b18d9#diff-a8e107ebe039de52ca112ac6ddfba6ebccd53b4f53030b986e13f019fe57a378 Capability to interpret world/local coordinates with various align_corners semantics. Reviewed By: bottler Differential Revision: D51855420 fbshipit-source-id: 834cd220c25d7f0143d8a55ba880da5977099dd6
-
Differential Revision: D51902460 fbshipit-source-id: 3ffc5d7d2da5c5d4e971ee8275bd999c709e0b12
-
- 05 12月, 2023 1 次提交
-
-
由 Jeremy Reizenstein 创作于
Summary: Fixes github.com/facebookresearch/pytorch3d/issues/1680 Reviewed By: MichaelRamamonjisoa Differential Revision: D51587889 fbshipit-source-id: e68ae32d7041fb9ea3e981cf2bde47f947a41ca2
-