• Daniel Roschka's avatar
    Improve searching for configured AWS credentials · b0d4cdb1
    Daniel Roschka 创作于
    The previous approach for finding AWS credentials was pretty naive and
    only covered contents of a single file (~/.aws/credentials by
    default).
    
    The AWS CLI documentation states various other ways to configure
    credentials which weren't covered:
    https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#credentials
    Even that aren't all ways, a look into the code shows:
    https://github.com/boto/botocore/blob/develop/botocore/credentials.py
    
    This commit changes the behavior so the hook will behave in a way
    that if the AWS CLI is able to obtain credentials from local files,
    the hook will find them as well.
    
    The changes in detail are:
    - detect AWS session tokens and handle them like secret keys.
    - always search credentials in the default AWS CLI file locations
      ( ~/.aws/config, ~/.aws/credentials, /etc/boto.cfg and ~/.boto)
    - detect AWS credentials configured via environment variables in
      AWS_SECRET_ACCESS_KEY, AWS_SECURITY_TOKEN and AWS_SESSION_TOKEN
    - check additional configuration files configured via environment
      variables (AWS_CREDENTIAL_FILE, AWS_SHARED_CREDENTIALS_FILE and
      BOTO_CONFIG)
    - print out the first four characters of each secret found in files to
      be checked in, to make it easier to figure out, what the secrets
      were, which were going to be checked in
    - improve error handling for parsing ini-files
    - improve tests
    
    There is a major functional change introduced by this commit:
    Locations the AWS CLI gets credentials from are always searched and
    there is no way to disable them. --credentials-file is still there to
    specify one or more additional files to search credentials in. It's
    the purpose of this hook to find and check files for found
    credentials, so it should work in any case. As this commit also
    improves error handling for not-existing or malformed configuration
    files, it should be no big deal.
    
    Receiving credentials via the EC2 and ECS meta data services is not
    covered intentionally, to not further increase the amount of changes
    in this commit and as it's probably an edge case anyway to have this
    hook running in such an environment.
    b0d4cdb1